Remove the unused compiled_autograd option #1939
Merged
+7
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
fegin
requested review from
allenwang28,
ebsmothers,
joecummings,
pbontrager,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
This was referenced Oct 27, 2025
xmfan
approved these changes
Oct 28, 2025
tianyu-l
approved these changes
Oct 28, 2025
[ghstack-poisoned]
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0) (oldest at bottom): * pytorch#1857 * __->__ pytorch#1939 TorchTitan doesn't need compiled_autograd, which is meant to support compiled DDP, but TorchTitan will adopt fully_shard-based replicate. Let's remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TorchTitan doesn't need compiled_autograd, which is meant to support compiled DDP, but TorchTitan will adopt fully_shard-based replicate. Let's remove it.