-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metadata format to save_file in FullModelHFCheckpointer
#1126
Conversation
`AutoModel.xx` classes from hf's transformers do not work otherwise, and an error because the metadata is `None` here: https://github.com/huggingface/transformers/blob/main/src/transformers/modeling_utils.py#L518-L522 That said, I only have very basic knowledge of this so might be wrong here. I personally had to re-save the model files with metadata added for them to work with `AutoModel...` classes.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1126
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3193d14 with merge base 52e3283 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @man-shar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hi @man-shar! Thanks for this super helpful PR - once you run the linting, we can get this merged.
|
thank you! just ran the linter and updated. |
AutoModel.xx
classes from hf's transformers do not work otherwise, and we get an error because the metadata isNone
while loading the model here: https://github.com/huggingface/transformers/blob/main/src/transformers/modeling_utils.py#L518-L522That said, I only have very basic knowledge of this so might be wrong here. I personally had to re-save the model files with metadata added for them to work with
AutoModel...
classes.Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
Adds pt metadata while saving safetensors in
FullModelHFCheckpointer
.Test plan
Let me know if I have to do any of these? Also how 😅 ?
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)
pre-commit install
)pytest tests
pytest tests -m integration_test