Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Flag for tune ls #1163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pbontrager
Copy link
Contributor

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Currently we have a number of recipes under dev that we would like to make accessible to users but still clearly signal to users that these are not as well tested and may have special dependencies. The current behavior is to list these all in "tune ls" which isn't ideal as it doesn't disclose the experimental nature of these recipes. One option would be to exclude them entirely from "tune ls" but then it makes it very difficult to use them outside of github.

The proposal here is to add an "experimental" flag to tune ls that displays the extra recipes. All of the recipes are always available in tune run, but if you want to view them in ls you must pass the extra flag. This is accomplished by adding an extra parameter to the recipe dataclass in _recipe_registry that allows some recipes to be marked as experimental. Then get_all_recipes can accept an argument "include_experimental". This is True for "tune run" and False by default for "tune ls".

Changelog

  • include_experimental added to get_all_recipes
  • experimental added to recipe dataclass
  • experimental flag added to tune ls
  • Updated unit test and cli rst
  • Fixed bug where dev recipes weren't included in project package

Test plan

Ran tests and test tune ls in terminal for expected outputs

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
    • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Copy link

pytorch-bot bot commented Jul 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1163

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit f2dae01 with merge base bbc48e0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pbontrager pbontrager requested a review from joecummings July 11, 2024 20:53
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2024
@@ -66,7 +66,7 @@ where = [""]
include = ["torchtune*", "recipes*"]

[tool.setuptools.package-data]
recipes = ["configs/*.yaml", "configs/*/*.yaml"]
recipes = ["configs/*.yaml", "configs/*/*.yaml", "configs/*/*/*.yaml"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use something like configs/**.yaml here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be configs/**/*.yaml to match any number of subdirectories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already landed the existing version in another PR. Also after thinking about it more maybe it's better to be explicit here anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants