Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update utils docs #1170

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update utils docs #1170

merged 1 commit into from
Jul 12, 2024

Conversation

RdoubleA
Copy link
Contributor

  • Expose generic model component builders to fix links in ModelType
  • Clean up setup_torch_profiler docstrings
  • Add more clarity on get_quantization_mode
  • Correct padded_collate docstring

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1170

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1fa69b4 with merge base cc92fa0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2024
joecummings
joecummings reviewed Jul 12, 2024
View reviewed changes
torchtune/utils/quantization.py

Currently supported:

- :class:`~torchao.quantization.quant_api.Int4WeightOnlyQuantizer`: "4w"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

joecummings
joecummings approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@RdoubleA RdoubleA merged commit 6f630c4 into pytorch:main Jul 12, 2024
29 checks passed
maximegmd pushed a commit to maximegmd/torchtune that referenced this pull request Jul 13, 2024
@RdoubleA @maximegmd
Update utils docs (pytorch#1170)
8ceb95e
pbontrager pushed a commit that referenced this pull request Jul 15, 2024
@RdoubleA
Update utils docs (#1170)
f7912c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RdoubleA @joecummings @facebook-github-bot