Add model+loss compile for full finetune single device #1319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses. #1228
Changelog
What are the changes made in this PR?
Add model+loss compile for full finetune single device. Basically the same as #1296
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)
pre-commit install
)pytest tests
pytest tests -m integration_test
Qwen2-1.5B with 8-bit Adam bs=4
tok/s almost doubles, similar to @ebsmothers results for Llama2-7B with QLoRA on A100. Also much better memory usage (I believe the logits are the culprit here). When bs=8, "compile model only" OOM, while "compile model+loss" is ok.
All runs are done with 4070Ti SUPER 16GB.