Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model+loss compile for full finetune single device #1319

Merged

Conversation

gau-nernst
Copy link
Contributor

@gau-nernst gau-nernst commented Aug 13, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses. #1228

Changelog

What are the changes made in this PR?

Add model+loss compile for full finetune single device. Basically the same as #1296

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Qwen2-1.5B with 8-bit Adam bs=4

tune run full_finetune_single_device --config qwen2/1.5B_full_single_device optimizer._component_=bitsandbytes.optim.AdamW8bit optimizer_in_bwd=False compile=True metric_logger._component_=torchtune.utils.metric_logging.WandBLogger batch_size=4 log_peak_memory_stats=True

image

tok/s almost doubles, similar to @ebsmothers results for Llama2-7B with QLoRA on A100. Also much better memory usage (I believe the logits are the culprit here). When bs=8, "compile model only" OOM, while "compile model+loss" is ok.

All runs are done with 4070Ti SUPER 16GB.

Copy link

pytorch-bot bot commented Aug 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1319

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ba66545 with merge base aba908c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2024
@gau-nernst gau-nernst marked this pull request as ready for review August 13, 2024 05:51
@SalmanMohammadi
Copy link
Collaborator

Nice to see you taking advantage of the small model configs : )
LGTM. Thank you for adding this.

@joecummings joecummings merged commit 0531dcb into pytorch:main Aug 13, 2024
20 checks passed
@gau-nernst gau-nernst deleted the compile_full_full_finetune_single branch August 13, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants