Adds __repr__ to Message #1757
Merged
Adds __repr__ to Message #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1757
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c4616d6 with merge base a8a64ec ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
joecummings
reviewed
Oct 7, 2024
torchtune/data/_messages.py
Outdated
| @@ -136,6 +136,10 @@ def _validate_message(self) -> None: | |||
| f"Only assistant messages can be tool calls. Found role {self.role} in message: {self.text_content}" | |||
| ) | |||
|
|
|||
| def __repr__(self) -> str: | |||
| content_only = [content["content"] for content in self.content] | |||
| return f"Message(role={self.role!r}, content={content_only!r})" | |||
There was a problem hiding this comment.
The repr call for role is not necessary as it will always just be a string.
RdoubleA
approved these changes
Oct 8, 2024
|
awesome awesome, thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Fixes #1639
Updating
__repr__configures the output for__str__as well. This PR diffs a little from the initial proposal by printing out the list of items. The content type is not printed out, since it can be inferred from the__repr__itself. i.e. strings are printed directly andImageuses the__repr__from PIL.Changelog
__repr__toMessage.Test plan
pre-commit install)pytest testspytest tests -m integration_testUX