Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM Eval tests #1887

Closed
wants to merge 25 commits into from
Closed

MM Eval tests #1887

wants to merge 25 commits into from

Conversation

SalmanMohammadi
Copy link
Collaborator

@SalmanMohammadi SalmanMohammadi commented Oct 23, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Adds some tests for the eval recipe using dummy Llama3.2 Vision models.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Oct 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1887

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@SalmanMohammadi SalmanMohammadi marked this pull request as draft October 23, 2024 16:46
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@SalmanMohammadi SalmanMohammadi mentioned this pull request Nov 7, 2024
15 tasks
@SalmanMohammadi SalmanMohammadi changed the title [WIP] MM Eval tests MM Eval tests Nov 8, 2024
@SalmanMohammadi SalmanMohammadi marked this pull request as ready for review November 8, 2024 14:29
]


def dummy_vision_model():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this in tests/torchtune/modules/test_common_utils.py, opportunity to unify?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It made the most sense to me to define the fixture where it was being used - do you have strong opinions here?

@@ -170,6 +170,7 @@ def llama3_2_vision_decoder(
by :func:`~torchtune.modules.KVCache`.
encoder_max_seq_len (int): maximum sequence length the encoder will be run with, as used
by :func:`~torchtune.modules.KVCache`.
rope_base (int): base for the rotary positional embeddings. Default: 500_000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did our linter not pick this up...

@SalmanMohammadi
Copy link
Collaborator Author

holy moly

 ============================= slowest 20 durations =============================
376.79s call     tests/recipes/test_eleuther_eval.py::TestEleutherEval::test_meta_eval_vision
342.01s call     tests/recipes/test_eleuther_eval.py::TestEleutherEval::test_hf_eval_vision

I fix

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 32.30769% with 44 lines in your changes missing coverage. Please review.

Project coverage is 24.78%. Comparing base (9eced21) to head (ed3f02e).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
tests/recipes/test_eleuther_eval.py 35.29% 33 Missing ⚠️
tests/recipes/utils.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1887       +/-   ##
===========================================
- Coverage   68.40%   24.78%   -43.62%     
===========================================
  Files         311      318        +7     
  Lines       16973    17649      +676     
===========================================
- Hits        11610     4375     -7235     
- Misses       5363    13274     +7911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SalmanMohammadi
Copy link
Collaborator Author

I DONT understand why this is failing, it's passing locally

@SalmanMohammadi
Copy link
Collaborator Author

im so done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants