Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old torchao imports, require 0.7.0+ #2513

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

andrewor14
Copy link
Contributor

These imports have been deprecated for 3 torchao versions already. Since torchtune only supports the latest torchao version, we remove these imports.

Copy link

pytorch-bot bot commented Mar 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2513

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1bec780 with merge base 1241231 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@andrewor14
Copy link
Contributor Author

@ebsmothers

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Once CI is green we can merge

These imports have been deprecated for 3 torchao versions already.
Since torchtune only supports the latest torchao version, we
remove these imports.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.02%. Comparing base (1241231) to head (1bec780).

Files with missing lines Patch % Lines
torchtune/training/quantization.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
- Coverage   66.98%   64.02%   -2.97%     
==========================================
  Files         378      373       -5     
  Lines       22527    21986     -541     
==========================================
- Hits        15090    14076    -1014     
- Misses       7437     7910     +473     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ebsmothers ebsmothers merged commit c370348 into pytorch:main Mar 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants