Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old recipe #338

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Delete old recipe #338

merged 4 commits into from
Feb 8, 2024

Conversation

kartikayk
Copy link
Contributor

@kartikayk kartikayk commented Feb 8, 2024

Context

#251 refactored our recipes but did not delete the old recipe. This PR removes any mention of the old recipe and associated config.

Changelog

  • Remove finetune_llm.py
  • Remove alpaca_llama2_finetune.yaml
  • Rename test_finetune_llm.py to test_full_finetune.py
  • Removing recipe docs - update to this is under review in Update Overview Doc #332

Test plan

Unit Tests succeed:

pytest tests
image

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for torchtune-preview ready!

Name Link
🔨 Latest commit e7915e1
🔍 Latest deploy log https://app.netlify.com/sites/torchtune-preview/deploys/65c4426c8478140008b82154
😎 Deploy Preview https://deploy-preview-338--torchtune-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 8, 2024
@joecummings
Copy link
Contributor

Can you update the docs, as well?

Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe README still references the old recipe, can we update?

@rohan-varma rohan-varma self-requested a review February 8, 2024 02:48
@joecummings
Copy link
Contributor

I believe README still references the old recipe, can we update?

The initial fine-tuning tutorial also references the old recipe.

@kartikayk kartikayk merged commit 4faa198 into main Feb 8, 2024
15 checks passed
@kartikayk kartikayk deleted the nuke_old_recipe branch February 8, 2024 03:07
@kartikayk
Copy link
Contributor Author

@joecummings #332 updates the tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants