-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HF CLI Upload to E2E Workflow tutorial #773
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/773
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3b7ce63 with merge base e9e082e (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
docs/source/tutorials/e2e_flow.rst
Outdated
-------------------------------------------- | ||
|
||
Your new model is working great and you want to share it with the world. The easiest way to do this | ||
is utilizing the ``huggingface-cli`` command, which is integrated with torchtune. Simply point the CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't believe it's integrated anymore, its more like interops or works seamlessly with
@@ -1,125 +0,0 @@ | |||
LLAMA 2 COMMUNITY LICENSE AGREEMENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this was here on purpose but it's an artifact of when we only supported llama2
|
||
.. code-block:: bash | ||
|
||
huggingface-cli upload <hf-repo-id> <checkpoint-dir> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: mention where the checkpoint will be saved by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll let @matthewdzmura comment on what to do about the licensing change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joecummings!
docs/source/tutorials/e2e_flow.rst
Outdated
|
||
.. note:: | ||
|
||
Before uploading, make sure you are authenticated with Hugging Face by running ``huggingface-cli login``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, You can also mention the "authentication" section from the quickstart guide (https://huggingface.co/docs/huggingface_hub/quick-start#authentication). And yeah, huggingface-cli login
is perfectly valid!
Context
huggingface-cli upload
command for a true e2e workflowChangelog
hf_upload
directoryTest plan