Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports in models/__init__.py #886

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ebsmothers
Copy link
Contributor

@ebsmothers ebsmothers commented Apr 26, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other: clean up code

Please link to any issues this PR addresses.

Changelog

  • Remove imports from torchtune/models/__init__.py. They aren't really needed since they are just importing directories that are already public and accessible, and it just causes a bit more friction adding each new model directory to this file.

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
    • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Ran the following:

>>> from torchtune.models import llama2
>>> llama2
<module 'torchtune.models.llama2' from '/data/users/ebs/ebs-torchtune/torchtune/models/llama2/__init__.py'>

>>> from torchtune.models.llama2 import llama2_7b
>>> llama2_7b
<function llama2_7b at 0x7fed49a40f70>

The results are the same with and without the imports in the __init__.py.

Copy link

pytorch-bot bot commented Apr 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/886

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0807bf9 with merge base cc2dd05 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2024
@ebsmothers ebsmothers marked this pull request as ready for review April 26, 2024 21:20
@ebsmothers ebsmothers changed the title remove unused models init Remove unused imports in models/__init__.py Apr 26, 2024
@ebsmothers ebsmothers merged commit 3890200 into pytorch:main Apr 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants