Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lora dropout applied to all models #995

Merged
merged 3 commits into from
May 17, 2024

Conversation

Optimox
Copy link
Contributor

@Optimox Optimox commented May 17, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Related to issue #996

Changelog

I only pass the lora_dropout argument where needed

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
    • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/995

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 408dbb5 with merge base f35e5d6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2024
@ebsmothers
Copy link
Contributor

Thanks @Optimox for finding this bug and making the fix! Can you also update the Mistral components while you're at it?

@Optimox
Copy link
Contributor Author

Optimox commented May 17, 2024

@ebsmothers yes you are right I forgot to update the mistral model! I've just added a new commit to take care of it!

@ebsmothers
Copy link
Contributor

Ah sorry just a couple more output layers.. here, here, and here. After that I think this should be good to go!

@joecummings joecummings linked an issue May 17, 2024 that may be closed by this pull request
@Optimox
Copy link
Contributor Author

Optimox commented May 17, 2024

@ebsmothers good catch! updated!

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for catching and fixing this. Just kicked off CI, once it's green I can merge.

@ebsmothers ebsmothers merged commit 9f31a88 into pytorch:main May 17, 2024
29 checks passed
weifengpy pushed a commit to weifengpy/torchtune that referenced this pull request Jun 4, 2024
maximegmd pushed a commit to maximegmd/torchtune that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants