Make docstring optional #259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
facebook-github-bot
added
the
CLA Signed
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Differential Revision: D31671125 fbshipit-source-id: 2fb71f6b98e212700479003ca4d15a01cec0e571
aivanou
force-pushed
the
export-D31671125
branch
from
c72a02e to
28e96f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Differential Revision: D31671125 fbshipit-source-id: 278c5a2dfaacc3dd604bd23ec3f44eaf21d13547
aivanou
force-pushed
the
export-D31671125
branch
from
28e96f7 to
ecb939f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 91.61% 91.56% -0.06%
==========================================
Files 60 60
Lines 2767 2749 -18
==========================================
- Hits 2535 2517 -18
Misses 232 232
Continue to review full report at Codecov.
|
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Differential Revision: D31671125 fbshipit-source-id: 32ea960b633460566bb7593f603ec524cbdd05d8
aivanou
force-pushed
the
export-D31671125
branch
from
ecb939f to
4348848
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Differential Revision: D31671125 fbshipit-source-id: 73a00ba8ba64fa1cdd4dc57008bf1ab050775bab
aivanou
force-pushed
the
export-D31671125
branch
from
4348848 to
a5b0483
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Differential Revision: D31671125 fbshipit-source-id: 2cb867f06742287019f628046eacdfca374e9aa6
aivanou
force-pushed
the
export-D31671125
branch
from
a5b0483 to
5cea44d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Git issue: pytorch#253 Differential Revision: D31671125 fbshipit-source-id: 5e7bd775fe1548ce46fc43108033db9b9cd0d1d6
aivanou
force-pushed
the
export-D31671125
branch
from
5cea44d to
f18d003
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Git issue: pytorch#253 Reviewed By: kiukchung Differential Revision: D31671125 fbshipit-source-id: 938faa5c0979d2b5e8c159384ebecc0274e95fff
aivanou
added a commit
to aivanou/torchx-1
that referenced
this pull request
Oct 15, 2021
Summary: Pull Request resolved: pytorch#259 * Refactor docstring functions: combines two functions that retrieve docstring into one * Make docstring optional * Remove docstring validator Git issue: pytorch#253 Reviewed By: kiukchung Differential Revision: D31671125 fbshipit-source-id: d391fc3ed9cfd7669bca93e8f6591fa6259367c3
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
aivanou
force-pushed
the
export-D31671125
branch
2 times, most recently
from
28f6cc7 to
bf29d7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31671125 |
|
This pull request has been merged in 74e07d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The diff makes the docstring optional when defining the component function.
Use argparse formatter that also prints default values
Differential Revision: D31671125