slurm_scheduler: add support for per replica log files and API access #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
slurmfixes
branch
2 times, most recently
from
470213e to
1aaa4b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 94.66% 94.73% +0.06%
==========================================
Files 61 61
Lines 3208 3227 +19
==========================================
+ Hits 3037 3057 +20
+ Misses 171 170 -1
Continue to review full report at Codecov.
|
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
torchx logsupport to the slurm scheduler. #371It writes out a
slurm-<jobid>-<role>-<replica_id>.outper worker with the combined stdout/stderr. We may want to split these in the future but for now it's fine. These files are logged out to the cwd per normal slurm behavior sotorchx logwill stop working if the user changes their working directory.Test plan:
Updated integration test to use
torchx loginstead ofslurm-<id>.out