torchx/runner: log events to torch.monitor #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33928333 |
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 94.83% 94.73% -0.11%
==========================================
Files 63 63
Lines 3347 3359 +12
==========================================
+ Hits 3174 3182 +8
- Misses 173 177 +4
Continue to review full report at Codecov.
|
Summary: This logs the `torchx.runner.events.Events` to `torch.monitor` as well as the existing event handlers. Once monitor is stable the existing ones will be removed entirely in favor of the new interface. `torch.monitor` is only available with pytorch 1.11 (or main) so it's a no-op if it's not available. Differential Revision: D33928333 fbshipit-source-id: 632a7e096f46e5c1946932d4a765be179e1e53a8
d4l3k
force-pushed
the
export-D33928333
branch
from
5cfd066 to
0f156ae
Compare
edward-io
reviewed
Feb 2, 2022
| @@ -59,6 +59,15 @@ def _get_or_create_logger(destination: str = "null") -> logging.Logger: | |||
| def record(event: TorchxEvent, destination: str = "null") -> None: | |||
| _get_or_create_logger(destination).info(event.serialize()) | |||
|
|
|||
| if destination != "console": | |||
There was a problem hiding this comment.
would it make sense to have a console event handler, so we don't need this check?
There was a problem hiding this comment.
I'm not actually sure we use console anywhere, this is mostly just to be safe. Easy enough to remove it if people need it.
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
added a commit
that referenced
this pull request
Jun 24, 2022
Summary: This reverts commit 4b989d5. Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS. This accounts for about 340ms of load time. Pull Request resolved: #536 Test Plan: This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler. Reviewed By: priyaramani, kurman Differential Revision: D37432126 Pulled By: d4l3k fbshipit-source-id: f38a89a7a4dbbd69e9ba43c130bd31b084c0bb00
d4l3k
added a commit
that referenced
this pull request
Jun 25, 2022
Summary: This reverts commit 4b989d5. Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS. This accounts for about 340ms of load time. Pull Request resolved: #536 Test Plan: This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler. Reviewed By: priyaramani, kurman Differential Revision: D37432126 Pulled By: d4l3k fbshipit-source-id: 410e25744ad26706e35eee8e10f90ef8f94514ee
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Summary: This reverts commit 4b989d5. Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS. This accounts for about 340ms of load time. Pull Request resolved: #536 Test Plan: This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler. Reviewed By: priyaramani, kurman Differential Revision: D37432126 Pulled By: d4l3k fbshipit-source-id: 6ad6c3b93ed2622f8d931b5c906841858646c2f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This logs the
torchx.runner.events.Eventstotorch.monitoras well as the existing event handlers. Once monitor is stable the existing ones will be removed entirely in favor of the new interface.torch.monitoris only available with pytorch 1.11 (or main) so it's a no-op if it's not available.Differential Revision: D33928333