Skip to content

Add automatic set of CUDA_VISIBLE_DEVICES for local scheduler #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aivanou
Copy link
Contributor

@aivanou aivanou commented Feb 8, 2022

Summary:
The diff adds automatic set of CUDA_VISIBLE_DEVICES based on num_replicas.

Each replica gets the same number of devices

The alg. applies only when CUDA_VISIBLE_DEVICES is not set

#297

#377

Differential Revision: D34064433

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Feb 8, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #383 (9b9f0bb) into main (f5278cc) will decrease coverage by 0.05%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   94.62%   94.57%   -0.06%     
==========================================
  Files          66       66              
  Lines        3554     3593      +39     
==========================================
+ Hits         3363     3398      +35     
- Misses        191      195       +4     
Impacted Files Coverage Δ
torchx/schedulers/local_scheduler.py 92.93% <90.69%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5278cc...9b9f0bb. Read the comment docs.

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 8, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 788ce92b0ad79e24f4be22bb2d5e9f784f25004b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 9, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 17c9df4d22e2c56ee65739db22714499e8daff18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 9, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 1bdada1765b6ce740c64e434b079353df4acb702
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 10, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: e9641e93fb487b38000f77c88b550a3149443f75
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 14, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: de22a96744bb5f625d331c970f529cb5d316ed27
aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 14, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 8436d962d4a3444608b4f86eb507598487c2cc5b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 14, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: fe30725bc81876e8dd712f311f86cfb66ba658fd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 15, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 8db12112f924c8d66b935d6b98f3a186ea5fa08c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 15, 2022
…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Differential Revision: D34064433

fbshipit-source-id: 3fee285d7b17d77abdbee8d9049f63b3a582943e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

…rch#383)

Summary:
Pull Request resolved: pytorch#383

The diff adds automatic set of `CUDA_VISIBLE_DEVICES` based on `num_replicas`.

Each replica gets the same number of devices

The alg. applies only when `CUDA_VISIBLE_DEVICES` is not set
The diff uses `nvidia-smi` to determine the number of GPUs

pytorch#297

pytorch#377

Reviewed By: kiukchung

Differential Revision: D34064433

fbshipit-source-id: 03719702eeaff1b8f5dfcc0c9cd36d54ff660499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34064433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants