Skip to content

slurm_scheduler: add more runopts. Fixes #389 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Feb 15, 2022

This adds 4 runopts:

  • constraint
  • comment
  • mail-user
  • mail-type

Test plan:

Added unit tests for all fields

Integ test for comment

Hard for us to test constraint since our cluster doesn't have any node constraints

torchx run --wait --scheduler slurm --scheduler_args partition=compute,time=10,comment=hello,mail-user=<addr>,mail-type=END utils.echo --num_replicas 3

This passes but I don't believe the mail from our cluster is deliverable.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #391 (e6285e0) into main (8b62ea8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   93.96%   93.98%   +0.01%     
==========================================
  Files          64       64              
  Lines        3565     3574       +9     
==========================================
+ Hits         3350     3359       +9     
  Misses        215      215              
Impacted Files Coverage Δ
torchx/schedulers/slurm_scheduler.py 98.11% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b62ea8...e6285e0. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants