Skip to content

docs: add documentation for workspaces + general cleanup #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Mar 1, 2022

This makes some of the changes listed in https://docs.google.com/document/d/14icG0GJG1nPHF3DW7yMreZpe3S8FwYdrI_XYIzDTSbI/edit#heading=h.6ixj5co4aocb

  • Adds workspaces documention
  • Adds coverage test to docs build to ensure all exported methods/classes are documented in the docs.
  • Adds previously undocumented methods/classes to docs
  • Moves torchconfig from experimental to beta
  • Splits docker/local scheduler docs
  • Reshuffles the sidebar to prioritize the schedulers over some of the other content

Next steps:

  • update readme/index/quickstart guides to highlight workspaces + patching w/ ddp builtin
  • deprioritize/remove some of the more complex custom component examples

Test plan:

$ make -C docs coverage; and cat docs/build/0.1.2dev0/coverage/python.txt
$ pyre
$ pytest

CI

Screenshot 2022-02-28 at 17-21-17 torchx workspace — PyTorch TorchX main documentation

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #402 (8edc8df) into main (ca86f97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files          66       66           
  Lines        3663     3664    +1     
=======================================
+ Hits         3463     3464    +1     
  Misses        200      200           
Impacted Files Coverage Δ
torchx/runner/config.py 100.00% <ø> (ø)
torchx/schedulers/ray_scheduler.py 93.93% <ø> (ø)
torchx/schedulers/slurm_scheduler.py 98.11% <ø> (ø)
torchx/specs/__init__.py 96.15% <ø> (ø)
torchx/workspace/api.py 83.33% <ø> (ø)
torchx/workspace/docker_workspace.py 95.19% <ø> (ø)
torchx/schedulers/__init__.py 96.66% <100.00%> (ø)
torchx/schedulers/aws_batch_scheduler.py 85.39% <100.00%> (ø)
torchx/schedulers/local_scheduler.py 92.95% <100.00%> (ø)
torchx/specs/file_linter.py 98.60% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca86f97...8edc8df. Read the comment docs.

d4l3k added a commit that referenced this pull request Mar 1, 2022
Summary:
This makes some of the changes listed in https://docs.google.com/document/d/14icG0GJG1nPHF3DW7yMreZpe3S8FwYdrI_XYIzDTSbI/edit#heading=h.6ixj5co4aocb

* Adds workspaces documention
* Adds coverage test to docs build to ensure all exported methods/classes are documented in the docs.
* Adds previously undocumented methods/classes to docs
* Moves torchconfig from experimental to beta
* Splits docker/local scheduler docs
* Reshuffles the sidebar to prioritize the schedulers over some of the other content

Next steps:

* update readme/index/quickstart guides to highlight workspaces + patching w/ ddp builtin
* deprioritize/remove some of the more complex custom component examples

Pull Request resolved: #402

Test Plan:
```
$ make -C docs coverage; and cat docs/build/0.1.2dev0/coverage/python.txt
$ pyre
$ pytest
```
CI
![Screenshot 2022-02-28 at 17-21-17 torchx workspace — PyTorch TorchX main documentation](https://user-images.githubusercontent.com/909104/156086755-8330fece-dc86-442d-a656-aaef775bd3e5.png)

Reviewed By: kiukchung

Differential Revision: D34540003

Pulled By: d4l3k

fbshipit-source-id: 585d2ad5f35d87c0451ba6fb1e3fd68b5e0e6e0e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34540003

Summary:
This makes some of the changes listed in https://docs.google.com/document/d/14icG0GJG1nPHF3DW7yMreZpe3S8FwYdrI_XYIzDTSbI/edit#heading=h.6ixj5co4aocb

* Adds workspaces documention
* Adds coverage test to docs build to ensure all exported methods/classes are documented in the docs.
* Adds previously undocumented methods/classes to docs
* Moves torchconfig from experimental to beta
* Splits docker/local scheduler docs
* Reshuffles the sidebar to prioritize the schedulers over some of the other content

Next steps:

* update readme/index/quickstart guides to highlight workspaces + patching w/ ddp builtin
* deprioritize/remove some of the more complex custom component examples

Pull Request resolved: #402

Test Plan:
```
$ make -C docs coverage; and cat docs/build/0.1.2dev0/coverage/python.txt
$ pyre
$ pytest
```
CI
![Screenshot 2022-02-28 at 17-21-17 torchx workspace — PyTorch TorchX main documentation](https://user-images.githubusercontent.com/909104/156086755-8330fece-dc86-442d-a656-aaef775bd3e5.png)

Reviewed By: kiukchung

Differential Revision: D34540003

Pulled By: d4l3k

fbshipit-source-id: 271b084d36bdf256547cae755fbeb0e603abac66
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34540003

@d4l3k d4l3k deleted the workspacedocs branch April 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants