(torchx/scheduler) configure srun to pump stderr to *.err file instead of having everything redirected to stdout #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34729144 |
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 94.21% 94.22%
=======================================
Files 66 66
Lines 3685 3689 +4
=======================================
+ Hits 3472 3476 +4
Misses 213 213
Continue to review full report at Codecov.
|
…d of having everything redirected to stdout (#414) Summary: Pull Request resolved: #414 Addresses the log related QOL mentioned #405. Split the stdout and stderr into two separate log files and make adjustments to the slurm_scheduler.log_iter implementation to support this. Reviewed By: d4l3k Differential Revision: D34729144 fbshipit-source-id: 7c05f8e30882dab35959278188a9f2deb698583e
|
This pull request was exported from Phabricator. Differential Revision: D34729144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses the log related QOL mentioned #405.
Split the stdout and stderr into two separate log files and make adjustments to the slurm_scheduler.log_iter implementation to support this.
Differential Revision: D34729144