Skip to content

slurm_scheduler: autodetect nomem setting #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

slurm_scheduler: autodetect nomem setting #461

wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Apr 15, 2022

This automatically infers nomem by using sinfo to get the Memory setting for the specified partition. If we can't determine the memory setting or its <= 1000 MB we disable memory allocation checks.

#405

Test plan:

CI

Slurm integration tests w/ nomem removed

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@d4l3k has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #461 (7fefe00) into main (37c76eb) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   94.59%   94.58%   -0.02%     
==========================================
  Files          65       65              
  Lines        3833     3858      +25     
==========================================
+ Hits         3626     3649      +23     
- Misses        207      209       +2     
Impacted Files Coverage Δ
torchx/schedulers/slurm_scheduler.py 96.84% <92.85%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c76eb...7fefe00. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@d4l3k has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@d4l3k has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@d4l3k d4l3k deleted the slurmmem branch May 20, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants