-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the kernel size from 3x3 to the original 5x5 #1257
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit 479ea7c https://deploy-preview-1257--pytorch-tutorials-preview.netlify.app |
Hi @matsui528! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
This PR reverts the kernel size from 3x3 to the original 5x5 at the beginning of the 60 Minute Blitz.
https://pytorch.org/tutorials/beginner/blitz/neural_networks_tutorial.html#neural-networks
The kernel size was originally 5x5, but #515 changed it to 3x3 to avoid confusion on the FC parameter. It indeed makes sense.
However, it turned out that there are some drawbacks:
After some discussion (#503 (comment) and 6308024#commitcomment-34816516), it seems the best way is to revert the kernel size from 3x3 to the original 5x5.