Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the kernel size from 3x3 to the original 5x5 #1257

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

matsui528
Copy link
Contributor

@matsui528 matsui528 commented Nov 23, 2020

This PR reverts the kernel size from 3x3 to the original 5x5 at the beginning of the 60 Minute Blitz.
https://pytorch.org/tutorials/beginner/blitz/neural_networks_tutorial.html#neural-networks

The kernel size was originally 5x5, but #515 changed it to 3x3 to avoid confusion on the FC parameter. It indeed makes sense.

However, it turned out that there are some drawbacks:

After some discussion (#503 (comment) and 6308024#commitcomment-34816516), it seems the best way is to revert the kernel size from 3x3 to the original 5x5.

@netlify
Copy link

netlify bot commented Nov 23, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 479ea7c

https://deploy-preview-1257--pytorch-tutorials-preview.netlify.app

@facebook-github-bot
Copy link
Contributor

Hi @matsui528!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@matsui528
Copy link
Contributor Author

I found three duplicate PRs, meaning a strong demand for revising this inconsistent description. #1003 #859 #835

As this is the beginning of the tutorial, should the description be precise with a consistent relation to the overview figure?

@matsui528
Copy link
Contributor Author

Related issues: #924 #839 #727 #724 #703 #694

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@holly1238 holly1238 requested review from subramen and ranman April 7, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants