Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update audio tutorials for 1.12 release #1939

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update audio tutorials for 1.12 release #1939

merged 1 commit into from
Jun 21, 2022

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Jun 8, 2022

Updating the tutorials from https://pytorch.org/audio/main/

@mthrok mthrok added the 1.12 PRs for 1.12 release label Jun 8, 2022
@mthrok mthrok requested a review from hwangjeff June 8, 2022 16:58
@netlify
Copy link

netlify bot commented Jun 8, 2022

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 627af1d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/62a0d4b0e360610008d24efb
😎 Deploy Preview https://deploy-preview-1939--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mthrok mthrok requested a review from holly1238 June 8, 2022 16:59
@mthrok mthrok changed the title Update audio tutorials for 0.12 Update audio tutorials for 1.12 release Jun 8, 2022
@mthrok mthrok changed the base branch from master to 1.12-RC-TEST June 8, 2022 17:02
@mthrok mthrok requested review from a team and removed request for hwangjeff June 8, 2022 17:05
@nateanl
Copy link
Member

nateanl commented Jun 8, 2022

Not sure, but are 599234a and bac07c7 the necessary fix for torchaudio's tutorials?

@mthrok
Copy link
Contributor Author

mthrok commented Jun 8, 2022

Not sure, but are 599234a and bac07c7 the necessary fix for torchaudio's tutorials?

It's the residual from master branch, let me rebase it on RC branch.

@mthrok mthrok marked this pull request as ready for review June 17, 2022 16:16
@mthrok mthrok closed this Jun 17, 2022
@mthrok mthrok reopened this Jun 17, 2022
@svekars svekars merged commit 46985e9 into pytorch:1.12-RC-TEST Jun 21, 2022
svekars pushed a commit that referenced this pull request Jun 21, 2022
Revert "Update audio tutorials for 0.12 (#1939)"
6d6a531 
This reverts commit 46985e9.
@mthrok mthrok deleted the update-audio-tutorials branch June 21, 2022 20:20
@mthrok mthrok mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateanl nateanl nateanl approved these changes

@holly1238 holly1238 Awaiting requested review from holly1238

Assignees
No one assigned
Labels
1.12 PRs for 1.12 release cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthrok @nateanl @svekars @facebook-github-bot