Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: beginner/onnx/onnx_registry_tutorial.py fails against 2.4 RC binaries #2950

Merged

Conversation

titaiwangms
Copy link
Contributor

@titaiwangms titaiwangms commented Jun 20, 2024

Fixes #2941

cc @xadupre

Description

This PR updates the ONNX graphs which are optimized by onnxscript/optimizer

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Jun 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2950

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3449480 with merge base 0dee5c9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars changed the base branch from main to 2.4-RC-TEST June 20, 2024 04:21
@svekars
Copy link
Contributor

svekars commented Jun 20, 2024

I changed the base branch to 2.4-RC where we pull the 2.4 binaries.

@titaiwangms
Copy link
Contributor Author

Hi, @svekars the CI looks acting weirdly. Could you re-trigger it?

@svekars svekars added the 2.4 label Jun 25, 2024
@svekars
Copy link
Contributor

svekars commented Jun 25, 2024

Can you please locally rebase on 2.4-RC-TEST and then enable the tuorial in .jenkins/validate_tutorials_built.py.

@titaiwangms titaiwangms force-pushed the titaiwang/adapt_optimizer_changes_to_graphs branch from 4edd225 to c05e8ec Compare June 25, 2024 22:46
@svekars svekars changed the base branch from 2.4-RC-TEST to main July 22, 2024 16:52
@svekars svekars changed the base branch from main to 2.4-RC-TEST July 22, 2024 16:52
@svekars svekars changed the base branch from 2.4-RC-TEST to main July 22, 2024 16:55
@svekars svekars merged commit 123dd5c into pytorch:main Jul 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - beginner/onnx/onnx_registry_tutorial.py fails against 2.4 RC binaries
4 participants