Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating Mobile Tutorials in favor of ExecuTorch #3121

Merged
merged 22 commits into from
Nov 4, 2024
Merged

Deprecating Mobile Tutorials in favor of ExecuTorch #3121

merged 22 commits into from
Nov 4, 2024

Conversation

AlannaBurke
Copy link
Contributor

@AlannaBurke AlannaBurke commented Oct 28, 2024 •
edited
Loading

Description

Redirects the following to Executorch:

Model Preparation for Android Recipe
(Prototype) Convert Mobilenetv2 to Core ML
Image Segmentation DeepLabV3 on Android
Image Segmentation DeepLabV3 on iOS
Summary of PyTorch Mobile Recipes
Model Preparation for iOS Recipe
(beta) Efficient mobile interpreter in Android and iOS
(Prototype) Use iOS GPU in PyTorch
Pytorch Mobile Performance Recipes
(Beta) Convert MobileNetV2 to NNAP

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3121

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a27d96e with merge base 32d2b29 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

svekars
svekars reviewed Oct 28, 2024
View reviewed changes
beginner_source/deeplabv3_on_android.rst Outdated
@@ -1,234 +1,10 @@
Image Segmentation DeepLabV3 on Android
=================================================

**Author**: `Jeff Tang <https://github.com/jeffxtang>`_
This tutorial has been deprecated. There is a new tutorial on this topic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably say something like: PyTorch Mobile is no longer actively supported. Please check out ExecuTorch.

svekars
svekars reviewed Oct 28, 2024
View reviewed changes
beginner_source/deeplabv3_on_android.rst Outdated
@@ -1,234 +1,10 @@
Image Segmentation DeepLabV3 on Android
=================================================

**Author**: `Jeff Tang <https://github.com/jeffxtang>`_
PyTorch Mobile is no longer actively supported. Please check out ExecuTorch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spellcheck still doesn't like it, let's make sure we spell ExecuTorch everywhere and add it to the https://github.com/pytorch/tutorials/blob/main/en-wordlist.txt

@svekars svekars changed the title Deprecating Tutorials for Tutorial Audit Deprecating Mobile Tutorials in favor of ExecuTorch Oct 29, 2024
svekars
svekars approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you make sure that all pages are redirecting correctly in the preview. For example: https://docs-preview.pytorch.org/pytorch/tutorials/3121/beginner/deeplabv3_on_android.html - After that good to merge.

@AlannaBurke
Copy link
Contributor Author

@svekars Checked each page and the redirect is working on each one.

@svekars svekars merged commit a551cdf into main Nov 4, 2024
20 checks passed
@svekars svekars deleted the deprecating-tutorials branch November 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@byjlw byjlw byjlw approved these changes

@ali-khosh ali-khosh Awaiting requested review from ali-khosh

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlannaBurke @byjlw @svekars @facebook-github-bot