Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid page links in tutorial #3205

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Dec 28, 2024

Links in the tutorial Inductor CPU backend debugging and profiling
is invalid, and leading to 404 pages.

Change troubleshooting and GPU performance profiling to valid url address

Test Result

Before
image

image

After
image

image

cc @svekars @brycebortree @sekyondaMeta @AlannaBurke @jgong5

Copy link

pytorch-bot bot commented Dec 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3205

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@AlannaBurke
Copy link
Contributor

Looks like the build is failing on a broken link not related to this PR. I've created an issue here: #3210

@svekars svekars added skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. incorrect link labels Jan 6, 2025
@svekars svekars merged commit 46943d6 into pytorch:main Jan 6, 2025
11 checks passed
@Valentine233
Copy link
Contributor

The link here is also invalid: https://github.com/pytorch/tutorials/blob/main/intermediate_source/inductor_debug_cpu.py#L346C76-L346C135. I have submitted a PR and please help review #3208. @svekars @zeshengzong

@zeshengzong zeshengzong deleted the fix/doc/link branch January 7, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed incorrect link skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants