Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v.0.13] Release Tracker #6083

Closed
atalman opened this issue May 24, 2022 · 1 comment
Closed

[v.0.13] Release Tracker #6083

atalman opened this issue May 24, 2022 · 1 comment
Labels
release-issue For release-related issues

Comments

@atalman
Copy link
Contributor

atalman commented May 24, 2022

We cut a release branch for the 0.13 release.

Our plan from this point from this point is roughly:

  • Phase 1 (until 06/13): work on finalizing the release branch
  • Phase 2 (after 06/13): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 06/13/22):

Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent minor release (e.g. 0.12 for 0.13 release; see module: regression issue list)
  2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Fixes to new features introduced in the most recent minor release (e.g. 0.12 for 0.13 release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
  7. Release branch specific changes (e.g. change version identifiers)

Any other change requires special dispensation from the release managers (currently @atalman, @seemethere ). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 06/13/22):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.13
    git checkout release/0.13
    git cherry-pick abcdef12345
    
    # Submit a PR based against 'release/0.13' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/0.13
  3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.13

@atalman atalman added the release-issue For release-related issues label May 24, 2022
@atalman atalman pinned this issue May 24, 2022
@datumbox
Copy link
Contributor

This is duplicate of #6081. Let's use the issue created originally by @NicolasHug.

@atalman atalman unpinned this issue May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-issue For release-related issues
Projects
None yet
Development

No branches or pull requests

2 participants