Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.13] Release Tracker #6081

Closed
NicolasHug opened this issue May 24, 2022 · 19 comments
Closed

[v0.13] Release Tracker #6081

NicolasHug opened this issue May 24, 2022 · 19 comments

Comments

@NicolasHug
Copy link
Member

NicolasHug commented May 24, 2022

We cut a release branch for the 0.13 release. (common commit with main is 69ce452)

This issue is for tracking cherry-picks to the release branch.
The POCs for the TorchVision team are @NicolasHug and @YosuaMichael

Cherry-Pick Criteria

Phase 1 (until 06/06/22):

Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent minor release (e.g. 0.12 for 0.13 release);
  2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Fixes to new features introduced in the most recent minor release (e.g. 0.12 for 0.13 release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
  7. Release branch specific changes (e.g. change version identifiers)

Phase 2 (after 06/06/22):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.13
    git checkout release/0.13
    git cherry-pick abcdef12345
    
    # Submit a PR based against 'release/0.13' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/0.13
  3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 
  1. the POC will reply with approved / denied or ask for more information.
  2. If approved, the PR can be merged once the tests pass.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.13

@YosuaMichael
Copy link
Contributor

YosuaMichael commented May 25, 2022

Fixing bug on resnet reported on #6074
PR for main: #6082
PR for release/0.13: #6085 (MERGED)
category: bugfix

@atalman atalman pinned this issue May 25, 2022
@YosuaMichael
Copy link
Contributor

YosuaMichael commented May 25, 2022

Handling edge cases on test_backbone_utils when the tracer sample nodes that is buffer with integer dtype, in this case the function Tensor.mean() will raise error since it does not accept integer. We add .float() before .mean() with this PR.

PR for main: #6090
PR for release/0.13: #6091 (MERGED)
category: bugfix

@YosuaMichael
Copy link
Contributor

YosuaMichael commented May 26, 2022

Refactor swin_transformer so it can be compatible with the 3d version (hence we dont introduce BC changes in the future release)

PR for main: #6088
PR for release/0.13: #6100 (MERGED)
category: backward compatibility

@atalman
Copy link
Contributor

atalman commented May 26, 2022

Link to landed master PR (if applicable):

  • NA

Link to release branch PR:

Criteria Category:

  • Critical CI fixes

@atalman merged

@YosuaMichael
Copy link
Contributor

Fix the CI error unsafe repo
PR for main: #6106
PR for release/0.13: #6109 (MERGED)

category: CI bugfix

@YosuaMichael
Copy link
Contributor

YosuaMichael commented May 31, 2022

Add M1 CI Build setup
PR for main: #5948, #6110, #6117, #6122, #6132, #6135, 6cf829d, #6140, #6146, #6158
PR for release/0.13: #6112 EDIT: #6167 (MERGED)

category: CI enhancement

@datumbox
Copy link
Contributor

Add missing _version to the MLPBlock
PR for main: #6113
PR for release/0.13: #6114

category: bugfix

@NicolasHug
Copy link
Member Author

NicolasHug commented Jun 6, 2022

#6117 might need to be cherry-picked as well. Waiting for @malfet 's input.

EDIT: included in #6112

@datumbox
Copy link
Contributor

datumbox commented Jun 8, 2022

#6135 might also need to be cherrypicked. Pretty much all M1 related commits + the BE work that Nicolas highlighted above need to be cherrypicked. I think we should do it once @malfet gives us the OK that all M1 related work is completed.

EDIT: included in #6112

@NicolasHug
Copy link
Member Author

#6133 might need to be cherry-picked as well

@NicolasHug
Copy link
Member Author

NicolasHug commented Jun 9, 2022

#6140 and #6146 as well

EDIT: included in #6112

@NicolasHug
Copy link
Member Author

NicolasHug commented Jun 9, 2022

Put back CelebA download

PR against main: #6147
PR for release branch: #6149

Category: critical fix (put back download functionality that we removed, but can now put back before the release).

@NicolasHug
Copy link
Member Author

NicolasHug commented Jun 10, 2022

Fix ViT and Resnext docs

PR on main: #6150
PR on release branch: #6151

Category: docs

@datumbox
Copy link
Contributor

Update _pil_constants.py to fix PIL SIMD

PR on main: #6154
PR on release branch: #6156

Category: bug fix

@NicolasHug
Copy link
Member Author

Fix minor typo in optical flow gallery example

Category: docs

main: #6163
release branch: #6164

@NicolasHug
Copy link
Member Author

Add new .. betastatus:: directive to document Beta APIs

Category: docs

main: #6115
release branch: #6165

@datumbox
Copy link
Contributor

datumbox commented Jun 16, 2022

Adding missing _log_api_usage_once to Swin's reusable components

Category: minor bugfix

main: #6174
release branch: #6175

@atalman this cherrypick comes after the final RC cut and it's not a critical bugfix, rather an omission on the logging side. I'll leave it up to you if it can be merged and included in the release.

@datumbox I think this is quite safe change, will improve user experience

@NicolasHug
Copy link
Member Author

Fix all broken URLs in docs

main PR: #6176
release branch PR: #6177

@atalman this one isn't critical either, just a nice-to-have as it fixes broken links in docs. Feel free to not merge it if it's a bit late

@NicolasHug
Copy link
Member Author

I think we're done with this one, thanks everyone for your help! Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants