-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _pil_constants.py #6154
Merged
Merged
Update _pil_constants.py #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a minor nit.
cc @NicolasHug, @YosuaMichael this would need to be cherrypicked into the release branch.
datumbox
added a commit
to datumbox/vision
that referenced
this pull request
Jun 11, 2022
* Update _pil_constants.py * Update _pil_constants.py * Fix flake8 * Fixed two related warnings in tests * switch dir with hasattr Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
This was referenced Jun 11, 2022
datumbox
added a commit
that referenced
this pull request
Jun 11, 2022
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 16, 2022
Summary: * Update _pil_constants.py * Update _pil_constants.py * Fix flake8 * Fixed two related warnings in tests * switch dir with hasattr Differential Revision: D37212661 fbshipit-source-id: 4495e7a73caf1e964d17649b8408e48394a25448 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Summary: * Update _pil_constants.py * Update _pil_constants.py * Fix flake8 * Fixed two related warnings in tests * switch dir with hasattr Reviewed By: datumbox Differential Revision: D37212661 fbshipit-source-id: de82b320b5d8d1a76f56dfe531678f2e81c5c3e0 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6153