0.14.0 Regression in wheel metadata

[groodt]

🐛 Describe the bug

The wheel metadata for the 0.14.0 release seems corrupt. It is not installable through installer, which means that it probably isn't installable using Hatch or PDM either.

The error is:

AssertionError: In /Users/groodt/Downloads/torchvision-0.14.0-cp39-cp39-manylinux1_x86_64.whl, torchvision-0.14.0.dist-info/RECORD is not mentioned in RECORD

Full reproduction and traceback here:

python3 -m pip install installer
python3 -m installer --destdir . ~/Downloads/torchvision-0.14.0-cp39-cp39-manylinux1_x86_64.whl
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/homebrew/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/private/tmp/blah/.venv/lib/python3.10/site-packages/installer/__main__.py", line 85, in <module>
    _main(sys.argv[1:], "python -m installer")
  File "/private/tmp/blah/.venv/lib/python3.10/site-packages/installer/__main__.py", line 81, in _main
    installer.install(source, destination, {})
  File "/private/tmp/blah/.venv/lib/python3.10/site-packages/installer/_core.py", line 96, in install
    for record_elements, stream, is_executable in source.get_contents():
  File "/private/tmp/blah/.venv/lib/python3.10/site-packages/installer/sources.py", line 158, in get_contents
    assert record is not None, "In {}, {} is not mentioned in RECORD".format(
AssertionError: In /Users/groodt/Downloads/torchvision-0.14.0-cp39-cp39-manylinux1_x86_64.whl, torchvision-0.14.0.dist-info/RECORD is not mentioned in RECORD

Versions

0.14.0

[groodt]

I've discovered that the following steps corrects the issue.

python3 -m wheel unpack --dest=/Users/groodt/Downloads/ ~/Downloads/torchvision-0.14.0-cp39-cp39-manylinux1_x86_64.whl
python3 -m wheel pack --dest-dir=/Users/groodt/Downloads/ ~/Downloads/torchvision-0.14.0/

[biphasic]

thanks for clarifying this. The PDM install indeed fails with that error

[ofek]

tried Hatch?

[1e100]

Bazel also fails with the same error when using pip_parse rule from rules_python.

[weiwangmeta]

Looks like the fix would be using @groodt 's command and re-upload the binaries?

[malfet]

Do we know what have caused the regression?
Also, imo we should produce correct binaries and publish the fix for 1.13.1 (if we are doing it).
Likely affects other wheels that we publish

[groodt]

I don’t think my “fix” would work exactly as is. It changes the wheel name. I’ve not looked too much into it, but something has changed that prevents this line from executing. I agree with finding the cause of the regression.

vision/packaging/wheel/relocate.py

Line 301 in b1f6c9e

f.write(f"{rel_file},,\n")

[weiwangmeta]

Confirmed 0.13.1 works "python3 -m installer --destdir . torchvision-0.13.1-cp39-cp39-manylinux1_x86_64.whl", so indeed a regression.
We will compare the difference between 0.13.1 and 0.14.0 cc @atalman

[bingoct]

version 0.13.1 is still installed fail by pdm.
Python version 3.8.10
Pdm version 2.2.1

 File "C:\Users\bingo\AppData\Roaming\Python\Python38\site-packages\installer\sources.py", line 158, in get_contents
    assert record is not None, "In {}, {} is not mentioned in RECORD".format(
AssertionError: In C:\Users\bingo\AppData\Local\Temp\pdm-build-5er6om93\torchvision-0.13.1-cp38-cp38-win_amd64.whl, torchvision-0.13.1.dist-info/LICENSE is not
mentioned in RECORD

Confirmed 0.13.1 works "python3 -m installer --destdir . torchvision-0.13.1-cp39-cp39-manylinux1_x86_64.whl", so indeed a regression. We will compare the difference between 0.13.1 and 0.14.0 cc @atalman