-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back MPS builds #8478
Comments
From #8456 (comment)
@malfet are the tests failing on your Mac with the same error message on |
I could reproduce the issue locally and can confirm that disable MPS makes |
This issue seems to appear in PyTorch commit between https://hud.pytorch.org/hud/pytorch/pytorch/d66f12674cfe0151a86dc10b8de216f83bf42e6e (failed) and https://hud.pytorch.org/hud/pytorch/pytorch/0ff2f8b52248323bbe25108b64e706c43390cb72 (success). I need to narrow this range down a bit. |
This reverts commit 669560d. Reverted #127265 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but I suspect that it causes this failure pytorch/vision#8478 on vision where its C++ extension could not be loaded on macOS ([comment](#127265 (comment)))
Since it can eliminate some linker warnings on MacOS Pull Request resolved: #127265 Approved by: https://github.com/ezyang, https://github.com/malfet
I think I have found the change responsible for this in pytorch/pytorch#127265. I have reverted it so that we can test it out in the next PyTorch nightly build. Reverting it locally fix the issue for me. |
Testing in #8485, but pending the revert https://hud.pytorch.org/hud/pytorch/pytorch/75b0720a97ac5d82e8a7a1a6ae7c5f7a87d7183d to get into the next PyTorch nightly build. |
This reverts commit 669560d. Reverted pytorch#127265 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but I suspect that it causes this failure pytorch/vision#8478 on vision where its C++ extension could not be loaded on macOS ([comment](pytorch#127265 (comment)))
(this is a follow-up and more up-to-date version of #8456)
The M1 CI jobs were broken for ~1 week (#8456) and it turns out the problem was caused by the MPS build. We deactivated the MPS builds in #8472 and the M1 jobs (all using
macos-m1-stable
) are now green.We have to put back the MPS build before the release though, otherwise torchvision won't provide MPS-compatible custom ops.
In #8476 (macos-m1-stable), #8473 (macos-m1-13) and #8477 (macos-m1-14) I'm trying to add back those MPS builds, but they all fail with the same error as previously seen back in #8456:
CC @malfet @huydhn
The text was updated successfully, but these errors were encountered: