ci: Add cu102 to CI and packaging, remove cu100 #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
force-pushed
the
add_cu102
branch
6 times, most recently
from
afd67a3 to
a34fc6d
Compare
|
@peterjc123 Do we not have cuda 10.2 on the windows executors? |
|
@seemethere No, CUDA 10.2 is not in the circleci image. You'll have to install it manually. |
Adds cu102 to our testing matrix as well as change the default manywheel version to be cu102. Also adds a function to get manylinux images instead of it being a conditional block. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
We removed the build for cu100 in upstream pytorch as well since we have begun to support cu102 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
changed the title
|
Thanks a lot @seemethere ! |
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Mar 20, 2020
* ci: Add cu102 to CI and packaging Adds cu102 to our testing matrix as well as change the default manywheel version to be cu102. Also adds a function to get manylinux images instead of it being a conditional block. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> * .circleci: Remove cu100, no longer built We removed the build for cu100 in upstream pytorch as well since we have begun to support cu102 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> * Fix lint * More lint fixes Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cu102 to our testing matrix as well as change the default manywheel
version to be cu102.
Signed-off-by: Eli Uriegas eliuriegas@fb.com