Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pil_to_tensor to functionals #2092
Add pil_to_tensor to functionals #2092
Changes from all commits
286e316
f7eb489
f90b3bc
9c2fd3b
08ab5ec
cb19ed4
38ad5f3
1fa91a8
0fefbcb
7662b23
75be7bb
123503a
eff1db0
266860a
610fc1e
b9cca77
1b10f77
fbf661c
598107f
d69048e
fa1084c
2cb7a4f
3d565fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will still produce the same bug mentioned in #2194. Converting to numpy with
np.asarray(pic)
will keep the PIL image non-writeable. If instead we usenp.array(pic)
, the bug #2194 would not appear. But I believe this is no real fix becausenp.array(pic)
copies the data which might be unintended behavior here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will wait until PyTorch fixes this behavior in master, as making a copy would be fairly expensive.
If the warnings are too annoying, an alternative would be to only use
asarray
if the array is writeable, and usearray
if it is non-writeable