Skip to content

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jun 2, 2020

This is a follow-up of #2282, trying to stack PRs by hand.

@fmassa fmassa requested a review from eellison June 2, 2020 14:44
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me - let's rresolve the nn.Module / normal class question in the other thread

@fmassa fmassa merged commit 9c20193 into hflip-script Jun 4, 2020
@fmassa fmassa deleted the vflip-script branch June 4, 2020 15:54
fmassa added a commit that referenced this pull request Jun 4, 2020
* Make RandomHorizontalFlip torchscriptable

* Make _is_tensor_a_torch_image more generic

* Make RandomVerticalFlip torchscriptable (#2283)

* Make RandomVerticalFlip torchscriptable

* Fix lint
@fmassa fmassa mentioned this pull request Jun 5, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants