[BC-breaking] Fix for integer fill value in constant padding #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmeier could you have a look to double-check? |
pmeier
approved these changes
Jun 4, 2020
pmeier
approved these changes
Jun 4, 2020
|
Thanks for the review @pmeier ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
padwith constant fill value had an undesired behavior when a single value was passed.One would expect that it would fill the whole region with the
(pad, pad, pad)value, but in fact it was doing(pad, 0, 0), as this is how Pillow handles it.This is a backwards-incompatible change in torchvision that changes the behavior of the function, but given that most users use a value of 0, this shouldn't be a big issue.