Skip to content

Adjust hue accepts torch tensor #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jun 11, 2020
Merged

Adjust hue accepts torch tensor #2300

merged 27 commits into from
Jun 11, 2020

Conversation

vikramtankasali
Copy link
Contributor

Add functionality to adjust hue for torch tensor type image.

fmassa
fmassa reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is looking very good!

I have a few comments that I think could be an improvement, let me know what you think

@fmassa fmassa mentioned this pull request Jun 10, 2020
Merged
fmassa
fmassa reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for getting this ready!

Lint is failing, and I have a few final suggestions for improvement, let me know what you think, but after that this is good to merge.

fmassa
fmassa approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot @vikramtankasali !

@fmassa fmassa merged commit 54da5db into pytorch:master Jun 11, 2020
@fmassa fmassa mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikramtankasali @fmassa