Skip to content

Update torchvision ops in doc #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Update torchvision ops in doc #2341

merged 2 commits into from
Jun 23, 2020

Conversation

zhiqwang
Copy link
Contributor

Noticed in #1586 , the deform_conv2d, PSPOIPool was not updated in Doc, so added in this PR.

And, the operator batched_nms is useful in many cases, would it be considered to be added in this pull request?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc improvements!

Originally batched_nms was experimental, but I think we can promote them now.

Also, I just noted that we can update the docs to mention that all operators now support torchscript, can you send a follow-up PR fixing this?

Comment on lines +24 to +25
.. autoclass:: MultiScaleRoIAlign
.. autoclass:: FeaturePyramidNetwork
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that those two were still a bit experimental, but enough time has passed already so I think we can add those as well

@@ -11,7 +11,15 @@ torchvision.ops

.. autofunction:: nms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, can you send a new PR changing line 9, as now all operators support torchscript.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #2343

@fmassa fmassa merged commit b6f55ed into pytorch:master Jun 23, 2020
@zhiqwang zhiqwang deleted the dcn-doc branch May 8, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants