Skip to content

Follow-up to #2368: Improved docs and tests for Crops with padding #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jun 30, 2020

Description:

This PR is a follow-up to #2368 with improved docs and tests for

  • RandomCrop: crop with padding using all commonly supported modes
  • pad in functional and functional_tensor

Additionally, make tests check results for class transforms between tensor and image.

- RandomCrop: crop with padding using all commonly supported modes
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2371 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
- Coverage   68.59%   68.54%   -0.06%     
==========================================
  Files          93       93              
  Lines        7713     7719       +6     
  Branches     1196     1199       +3     
==========================================
  Hits         5291     5291              
- Misses       2077     2080       +3     
- Partials      345      348       +3     
Impacted Files Coverage Δ
torchvision/transforms/functional.py 78.05% <ø> (ø)
torchvision/transforms/functional_tensor.py 62.85% <ø> (-2.24%) ⬇️
torchvision/transforms/transforms.py 77.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe11d5...5d23f11. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Victor!

@fmassa fmassa merged commit e50c2e3 into pytorch:master Jun 30, 2020
@vfdev-5 vfdev-5 deleted the vfdev-5/improve-crop-docs-tests branch June 30, 2020 16:03
de-vri-es pushed a commit to fizyr-forks/torchvision that referenced this pull request Aug 4, 2020
- RandomCrop: crop with padding using all commonly supported modes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants