Skip to content

[WIP] Allow autocast for 1.6 (#2384) #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jul 9, 2020

  • Fixes Xiao's repro

  • Ports nms to use full dispatcher

  • Move HIPGuard to nms_cuda

  • clang-format

  • run models in test_models.py on GPU if available

  • Francisco's comment, also disable cuda model tests to see if CPU alone still passes

  • cuda tests now pass locally, although still not comparing to saved numerics

  • add note for thing to ask francisco

  • Allow cuda and cpu tests to share a data file

  • ignore suffix if unneeded

  • Skip autocast numerics checks for a few models

  • Add roi_align test

Co-authored-by: Michael Carilli mcarilli@nvidia.com

* Fixes Xiao's repro

* Ports nms to use full dispatcher

* Move HIPGuard to nms_cuda

* clang-format

* run models in test_models.py on GPU if available

* Francisco's comment, also disable cuda model tests to see if CPU alone still passes

* cuda tests now pass locally, although still not comparing to saved numerics

* add note for thing to ask francisco

* Allow cuda and cpu tests to share a data file

* ignore suffix if unneeded

* Skip autocast numerics checks for a few models

* Add roi_align test

Co-authored-by: Michael Carilli <mcarilli@nvidia.com>
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2442 into release/0.7 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/0.7    #2442   +/-   ##
============================================
  Coverage        68.58%   68.58%           
============================================
  Files               93       93           
  Lines             7608     7608           
  Branches          1159     1159           
============================================
  Hits              5218     5218           
  Misses            2064     2064           
  Partials           326      326           
Impacted Files Coverage Δ
torchvision/ops/poolers.py 97.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e29a4...fc7d027. Read the comment docs.

@fmassa fmassa merged commit e873ea2 into pytorch:release/0.7 Jul 9, 2020
@fmassa fmassa deleted the import_autocast_0.7 branch July 9, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants