perform cyclic check for hue in test_rgb2hsv #2477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fails for cases when hue=0 and hue=360. As hue is cyclic in nature, add cyclic logic for checking the max difference by taking the sin of the tensor and then comparing the max values.
pmeier
requested changes
Jul 16, 2020
There was a problem hiding this comment.
Hi @KushajveerSingh and thanks for the fix. The linter failed with
./test/test_functional_tensor.py:4:12: W291 trailing whitespace
./test/test_functional_tensor.py:118:69: E231 missing whitespace after ','
./test/test_functional_tensor.py:119:75: E231 missing whitespace after ','
./test/test_functional_tensor.py:120:1: W293 blank line contains whitespace
./test/test_functional_tensor.py:121:42: E226 missing whitespace around arithmetic operator
./test/test_functional_tensor.py:121:44: E226 missing whitespace around arithmetic operator
./test/test_functional_tensor.py:121:75: E226 missing whitespace around arithmetic operator
./test/test_functional_tensor.py:121:77: E226 missing whitespace around arithmetic operator
Could you address that? Otherwise LGTM.
pmeier
approved these changes
Jul 16, 2020
|
Made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2433