Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add UCF101 dataset tests #2548

Merged
merged 11 commits into from
Aug 4, 2020
Merged

PR: Add UCF101 dataset tests #2548

merged 11 commits into from
Aug 4, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Aug 3, 2020

See #963

@andfoy andfoy self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #2548 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
+ Coverage   70.73%   71.32%   +0.59%     
==========================================
  Files          94       94              
  Lines        8029     8029              
  Branches     1275     1275              
==========================================
+ Hits         5679     5727      +48     
+ Misses       1946     1897      -49     
- Partials      404      405       +1
Impacted Files Coverage Δ
torchvision/datasets/utils.py 58.53% <0.00%> (+1.82%) ⬆️
torchvision/datasets/video_utils.py 84.84% <0.00%> (+9.09%) ⬆️
torchvision/datasets/ucf101.py 89.58% <0.00%> (+62.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6a796...8467b2d. Read the comment docs.

@andfoy andfoy marked this pull request as ready for review August 4, 2020 02:45
@andfoy
Copy link
Contributor Author

andfoy commented Aug 4, 2020

@fmassa, this one is ready for review!

fmassa
fmassa approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@fmassa fmassa merged commit 23295fb into pytorch:master Aug 4, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@andfoy @bryant1410
PR: Add UCF101 dataset tests (pytorch#2548)
9e60e70 
* Add fake data generator for UCF101

* Minor error correction

* Reduce total number of categories

* Fix naming

* Increase length

* Store in uint8

* Close fds

* Add assertGreater

* Add dimension tests

* Use numel instead of size

* Iterate over folds and splits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

@andfoy andfoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @fmassa