-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix package #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix package #31
Conversation
|
||
setup_info = dict( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@soumith hmm github should be rendering it... these are the problems with on-the-fly conversion. |
@soumith if you |
@soumith ok that's the readme fixed. |
@soumith here's what it looks like on PyPI https://pypi.org/project/torchvision/0.1.6.dev0/ |
this is awesome! thank you so much for fixing the readme formatting. Did you already upload it to pypi, or do I have to do anything further? |
The main torch repo will need the same treatment. It should be easy with pandoc and docutils and some fiddling about |
Yeah I'll push it to PyPI in the morning |
I need to also build a proper wheel for the main torch repo. Right now it's a bit of a hack via: https://github.com/pytorch/builder/blob/master/wheel/build_wheel.sh Your restructuring on this repo helped me understand what needs to be done. Thanks. In the future when new releases happen, can I upload to PyPI? I'm going to sit and read the docs for that in the next couple of days. |
You need to fix this so it generates manylinux1 wheels |
Otherwise it's not portable |
Hey there, welcome to Python!
Here we use reStructuredText rather than markdown because it renders as HTML on PyPI.