Skip to content

fix package #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2017
Merged

fix package #31

merged 3 commits into from
Jan 19, 2017

Conversation

graingert
Copy link

@graingert graingert commented Jan 18, 2017

Hey there, welcome to Python!

Here we use reStructuredText rather than markdown because it renders as HTML on PyPI.


setup_info = dict(

This comment was marked as off-topic.

This comment was marked as off-topic.

@soumith
Copy link
Member

soumith commented Jan 18, 2017

hi, the README looks much worse after this change on github. Is there a way to keep it as markdown? Maybe we can use an on the fly md -> rst converter?

screen shot 2017-01-18 at 6 44 32 pm

@graingert
Copy link
Author

@soumith hmm github should be rendering it... these are the problems with on-the-fly conversion.

@graingert
Copy link
Author

@soumith if you pip install docutils and run python3 setup.py check -r -s you'll be able to see what's up. It looks like pandoc has converted some of the headings incorrectly.

@graingert
Copy link
Author

@soumith ok that's the readme fixed.

@graingert
Copy link
Author

@soumith here's what it looks like on PyPI https://pypi.org/project/torchvision/0.1.6.dev0/

@soumith soumith merged commit 048f6f5 into pytorch:master Jan 19, 2017
@soumith
Copy link
Member

soumith commented Jan 19, 2017

this is awesome! thank you so much for fixing the readme formatting.

Did you already upload it to pypi, or do I have to do anything further?

@graingert
Copy link
Author

The main torch repo will need the same treatment. It should be easy with pandoc and docutils and some fiddling about

@graingert
Copy link
Author

Yeah I'll push it to PyPI in the morning

@soumith
Copy link
Member

soumith commented Jan 19, 2017

I need to also build a proper wheel for the main torch repo. Right now it's a bit of a hack via: https://github.com/pytorch/builder/blob/master/wheel/build_wheel.sh

Your restructuring on this repo helped me understand what needs to be done. Thanks.

In the future when new releases happen, can I upload to PyPI? I'm going to sit and read the docs for that in the next couple of days.

@graingert
Copy link
Author

You need to fix this so it generates manylinux1 wheels

@graingert
Copy link
Author

Otherwise it's not portable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants