Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for HMDB51 dataset #3458

Merged
merged 5 commits into from
Mar 1, 2021
Merged

add tests for HMDB51 dataset #3458

merged 5 commits into from
Mar 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 25, 2021

No description provided.

@pmeier pmeier mentioned this pull request Feb 25, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

Merging #3458 (ad6d8f3) into master (1826e92) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
+ Coverage   76.08%   76.54%   +0.45%     
==========================================
  Files         105      105              
  Lines        9707     9703       -4     
  Branches     1556     1556              
==========================================
+ Hits         7386     7427      +41     
+ Misses       1839     1795      -44     
+ Partials      482      481       -1
Impacted Files Coverage Δ
torchvision/datasets/kinetics.py 40.00% <0.00%> (-56.00%) ⬇️
torchvision/datasets/phototour.py 25.25% <0.00%> (+<0.01%) ⬆️
torchvision/transforms/functional_tensor.py 79.23% <0.00%> (+0.19%) ⬆️
torchvision/models/detection/anchor_utils.py 94.66% <0.00%> (+1.33%) ⬆️
torchvision/ops/deform_conv.py 72.30% <0.00%> (+3.07%) ⬆️
torchvision/datasets/cifar.py 95.00% <0.00%> (+5.00%) ⬆️
torchvision/extension.py 67.21% <0.00%> (+13.11%) ⬆️
torchvision/datasets/hmdb51.py 95.00% <0.00%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1826e92...5b9e5cb. Read the comment docs.

datumbox
datumbox approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmassa fmassa merged commit e9a9493 into pytorch:master Mar 1, 2021
@pmeier pmeier deleted the hmdb51-tests branch March 1, 2021 12:47
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
@zhangguanheng66 @datumbox @facebook-github-bot
add tests for HMDB51 dataset (#3458)
0eaa49c 
Summary:
* add tests for HMDB51 dataset

* lint

Reviewed By: fmassa

Differential Revision: D26756280

fbshipit-source-id: 9a13c7fd3f115da6b8051b7deeea81faccd36f0b

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: datasets module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmeier @datumbox @fmassa @NicolasHug @facebook-github-bot