Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port test/test_utils.py to pytest #3917

Merged
merged 2 commits into from
May 25, 2021

Conversation

zhiqwang
Copy link
Contributor

Hi @NicolasHug

This PR is to close #3909

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhiqwang ! Minor comment but LGTM when green!

test/test_utils.py Show resolved Hide resolved
@NicolasHug NicolasHug merged commit 154283b into pytorch:master May 25, 2021
@NicolasHug
Copy link
Member

Thanks!

@zhiqwang zhiqwang deleted the refactor-test-utils branch May 26, 2021 00:07
facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2021
Reviewed By: NicolasHug

Differential Revision: D29027311

fbshipit-source-id: d1a2003aa2a2ff2cf197e13aa7a3d93317aa8f91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port test/test_utils.py to pytest
4 participants