Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility to draw keypoints #4216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility to draw keypoints #4216
Changes from all commits
b2f6615
4fb038d
deda5d7
5490821
4cfc220
6306746
e8c93cf
73abf84
2ebe0c7
77afa81
cdeebdd
fad0d44
76af22e
1291f44
b9af874
28ebcc0
8db61f7
ebe7a25
e6afa37
c46d9db
691562c
4a65900
d5747d3
a034137
1f41550
d9d96cb
e6e7428
c8da898
4385643
8997b58
0002677
949e42c
693ffdc
00db80b
41ecc44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be the line color? Should there be a parameter for line color? Or should it be same as color of keypoints?
Currently it is white which looks bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of getting this merged soon, let's leave it white for now, and in the future create an issue to enable this to be configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have sufficient time before the next release. Let's discuss about this as well.