Skip to content

Fix for make_grid with 0.4 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2018
Merged

Fix for make_grid with 0.4 #469

merged 1 commit into from
Apr 12, 2018

Conversation

ssnl
Copy link
Contributor

@ssnl ssnl commented Apr 11, 2018

min/max returns 0 dim tensors now

fmassa
fmassa approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
What do you think, should we wait until 0.4 is released before merging this in?

@ssnl
Copy link
Contributor Author

ssnl commented Apr 11, 2018 •
edited
Loading

I think this should be fine as torchvision has actual versioned release. For repos like example and tutorial we need to push to a new branch. :)

@fmassa fmassa merged commit 1a6038e into pytorch:master Apr 12, 2018
@ssnl ssnl deleted the make_grid branch April 12, 2018 14:07
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
@ssnl @varunagrawal
Fix for min/max returning 0dim tensors now (pytorch#469)
b28013d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssnl @fmassa