Cleanup Models prototype implementation #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 4299eb3 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
changed the title
NicolasHug
approved these changes
Nov 16, 2021
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @datumbox , LGTM when green!
Contributor
Author
|
The failure is unrelated (flakiness). Merging. |
5 tasks
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Disable WeightEntry to pass-through `Weights.verify()` * Rename `Weights.state_dict()` to `Weights.get_state_dict()` * Add TODO for missing doc. * Moving warning messages for googlenet. * Upper-case global `_COMMON_META` var * Replace argument with parameter in all warnings.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
Summary: * Disable WeightEntry to pass-through `Weights.verify()` * Rename `Weights.state_dict()` to `Weights.get_state_dict()` * Add TODO for missing doc. * Moving warning messages for googlenet. * Upper-case global `_COMMON_META` var * Replace argument with parameter in all warnings. Reviewed By: datumbox Differential Revision: D32470468 fbshipit-source-id: 3781d23e8570bad1d63652a35fe55be313501c89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #4652
Addresses some of the comments at #4937. Each commit in this PR addresses a single of the comments below, so it can be seen as a stacked diff:
Weights.verify()- NOMRG Comments on prototype weights and model builders #4937 (comment)Weights.state_dict()toWeights.get_state_dict()- NOMRG Comments on prototype weights and model builders #4937 (comment)_COMMON_METAvar - NOMRG Comments on prototype weights and model builders #4937 (comment)cc @datumbox @bjuncek