-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Added center arg to F.affine and RandomAffine ops #5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 76dbebf (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vfdev-5 Thanks for the PR. The changes look good, I only added a comment for an unimplemented feature left in.
I think it would be useful also to document a bit the approach of this PR by adding references to specific papers or implementations that follow your approach for centering.
5130e47
to
7ad7312
Compare
7ad7312
to
f75bfb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vfdev-5.
Summary: * Added center option to F.affine and RandomAffine ops * Updates according to the review Reviewed By: kazhang Differential Revision: D33927487 fbshipit-source-id: 3e6562977c7948331982fa5f788f7933744917ac
Related to #5204
Description:
center
arg to F.affine and RandomAffine opsExample from #5204 (comment)