Fix broken progress bar #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
Jun 3, 2018
torchvision/datasets/utils.py
Outdated
| @@ -45,15 +47,22 @@ def download_url(url, root, filename, md5): | |||
| if os.path.isfile(fpath) and check_integrity(fpath, md5): | |||
| print('Using downloaded and verified file: ' + fpath) | |||
| else: | |||
| pbar_ctor = tqdm_notebook if '__IPYTHON__' in locals() else tqdm | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Fix broken update calculation - Make progress bar use the neat `unit_scale` feature of tqdm
|
Thanks @vfdev-5, good to know. But as I mentioned, the The plain progress bar also works decently in notebooks I think. |
kohr-h
changed the title
|
See tqdm/tqdm#394 |
varunagrawal
pushed a commit
to varunagrawal/vision
that referenced
this pull request
Jul 23, 2018
- Fix broken update calculation - Make progress bar use the neat `unit_scale` feature of tqdm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes to make the downloads look nicer:
unit_scalefeatureof tqdm
Usenot working, removedtqdm_notebookin an IPython environment