Skip to content

Fix broken progress bar #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2018
Merged

Fix broken progress bar #524

merged 1 commit into from
Jun 6, 2018

Conversation

@kohr-h
Copy link
Contributor

@kohr-h kohr-h commented Jun 3, 2018 •
edited
Loading

Some minor fixes to make the downloads look nicer:

  • Fix broken update calculation
  • Make progress bar use the neat unit_scale feature
    of tqdm
  • Use tqdm_notebook in an IPython environment not working, removed

vfdev-5
vfdev-5 reviewed Jun 3, 2018
View reviewed changes
torchvision/datasets/utils.py Outdated
if os.path.isfile(fpath) and check_integrity(fpath, md5):
print('Using downloaded and verified file: ' + fpath)
else:
pbar_ctor = tqdm_notebook if '__IPYTHON__' in locals() else tqdm

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@kohr-h
Fix broken progress bar
9c956e7 
- Fix broken update calculation
- Make progress bar use the neat `unit_scale` feature
  of tqdm
@vfdev-5
Copy link
Contributor

vfdev-5 commented Jun 4, 2018

@kohr-h there is a way to distinguish whether in jupyter notebook or in a script file like this

@kohr-h
Copy link
Contributor Author

kohr-h commented Jun 4, 2018

Thanks @vfdev-5, good to know. But as I mentioned, the tqdm_notebook seems to be broken anyway -- I'm getting NameError: name 'IntProgress' is not defined. As it seems, the code hasn't been updated for IPython versions > 4.

The plain progress bar also works decently in notebooks I think.

@kohr-h kohr-h changed the title Fix broken progress bar and improve for IPython Fix broken progress bar Jun 4, 2018
@kohr-h
Copy link
Contributor Author

kohr-h commented Jun 4, 2018

See tqdm/tqdm#394

fmassa
fmassa approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fmassa fmassa merged commit 50b2f91 into pytorch:master Jun 6, 2018
@kohr-h kohr-h deleted the fix_progress_bar branch June 20, 2018 17:15
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
@kohr-h @varunagrawal
Fix broken progress bar (pytorch#524)
60709d0 
- Fix broken update calculation
- Make progress bar use the neat `unit_scale` feature
  of tqdm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

+1 more reviewer

@vfdev-5 vfdev-5 vfdev-5 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kohr-h @vfdev-5 @fmassa