Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize dataset doc page into sections #5368

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Feb 3, 2022

Closes #5321

Largely based off @pmeier 's categorization in #5336

Rendered docs can be seen here: https://1171917-73328905-gh.circle-artifacts.com/0/docs/datasets.html

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 3, 2022

💊 CI failures summary and remediations

As of commit fed9ac0 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

:toctree: generated/
:template: class_dataset.rst

CocoCaptions
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what to do with this one so I created a section just for it. There might be a better alternative?

:template: class_dataset.rst

CocoDetection
CelebA
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some datasets here also appear in the Classification section:

  • CelebA
  • GTSRB
  • OxfordIIITPet

Perhaps there are others that I missed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to have them in both categories, since they can be used for both tasks. Looking through list, nothing missing comes to mind.

Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @NicolasHug! LGTM if CI is green.

:template: class_dataset.rst

CocoDetection
CelebA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to have them in both categories, since they can be used for both tasks. Looking through list, nothing missing comes to mind.

@NicolasHug NicolasHug merged commit 44e93be into pytorch:main Feb 3, 2022
KMNIST
LFWPeople
LFWPairs
LSUN
Copy link
Contributor

@oke-aditya oke-aditya Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSUN
Image Generation probably? This is how paperswithcode describes it as well. Also GANs are popular on this.

@@ -35,61 +37,105 @@ You can also create your own datasets using the provided :ref:`base classes <bas
CelebA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CelebA is image generation too.

SEMEION
Sintel
SBU
StanfordCars
STL10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tihnk STL-10 is used for g unsupervised learning. Although it can be used for image classification too.
That's how the website describes it https://cs.stanford.edu/~acoates/stl10/

@oke-aditya
Copy link
Contributor

cc @NicolasHug and @pmeier I guess we need a category for image generation, not sure about STL though.

facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2022
Reviewed By: NicolasHug

Differential Revision: D34140255

fbshipit-source-id: e171a94fbc24201aa10d7302035696df1955804a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More details to the dataset documentation page
4 participants