Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places365 dataset #5382

Closed
wants to merge 4 commits into from
Closed

Places365 dataset #5382

wants to merge 4 commits into from

Conversation

Amapocho
Copy link

@Amapocho Amapocho commented Feb 7, 2022

Added necessary links, categories and dependencies as a starting point for places365 #5347

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 7, 2022

💊 CI failures summary and remediations

As of commit 3a37185 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build lint_python_and_config (1/1)

Step: "Lint Python code and config files" (full log | diagnosis details | 🔁 rerun)

raise parse_error or Exception("unknown parse failure")
    return [fn(*args) for args in chunk]
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/ufmt/core.py", line 84, in ufmt_file
    dst_contents = ufmt_string(path, src_contents, usort_config, black_config)
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/ufmt/core.py", line 43, in ufmt_string
    content = usort_string(content, usort_config, path)
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/usort/sorting.py", line 257, in usort_string
    return usort_bytes(data=data.encode(), config=config, path=path)[0].decode()
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/usort/sorting.py", line 269, in usort_bytes
    mod = try_parse(data=data, path=path)
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/usort/util.py", line 77, in try_parse
    raise parse_error or Exception("unknown parse failure")
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/usort/util.py", line 67, in try_parse
    data, cst.PartialParserConfig(python_version=version)
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/libcst/_parser/entrypoints.py", line 114, in parse_module
    detect_default_newline=True,
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/libcst/_parser/entrypoints.py", line 61, in _parse
    detect_default_newline=detect_default_newline,
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/libcst/_parser/entrypoints.py", line 89, in _pure_python_parse
    result = parser.parse()
  File "/home/circleci/.cache/pre-commit/repogk91z6o_/py_env-python3.7/lib/python3.7/site-packages/libcst/_parser/base_parser.py", line 110, in parse
    self._add_token(token)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Amapocho Amapocho changed the title Places365 dataset #5347 Places365 dataset Feb 7, 2022
@pmeier
Copy link
Collaborator

pmeier commented Feb 7, 2022

Hey @Amapocho, would you please allow me to push some updates to this branch? I have a local cleanup commit that could help others start with this dataset.

@Amapocho
Copy link
Author

Amapocho commented Feb 7, 2022

Hey @Amapocho, would you please allow me to push some updates to this branch? I have a local cleanup commit that could help others start with this dataset.

Yeah, should I add you as a collaborator or should I just accept a pull request from your side?

@pmeier
Copy link
Collaborator

pmeier commented Feb 7, 2022

The easiest is if you simply check this box

2022-02-07_16-27

that is located at the bottom of the right column of a PR. With that you grant us push access to just this branch.

@Amapocho
Copy link
Author

Amapocho commented Feb 7, 2022

The easiest is if you simply check this box

that is located at the bottom of the right column of a PR. With that you grant us push access to just this branch.

I already have ticked the box so shouldn't be an issue

@pmeier
Copy link
Collaborator

pmeier commented Feb 7, 2022

Ah, I see. You made your changes on the main branch. Since your fork inherits our options and we have a push protection for the main branch, I can't push. In general, you should do your development on a feature branch. As a rule of thumb, unless you actually want to diverge from the upstream repository, you should not touch main of your fork.

I think the easiest way out here is to simply create a new branch from the commit you made and resend the PR:

git checkout -b places365

and push the new branch.

@Amapocho Amapocho closed this Feb 7, 2022
@Amapocho
Copy link
Author

Amapocho commented Feb 7, 2022

In general, you should do your development on a feature branch. As a rule of thumb, unless you actually want to diverge from the upstream repository, you should not touch main of your fork.

Thanks a lot, I did not know about it beforehand. I have made the necessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants